Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XLA tests updated #1413

Merged
merged 1 commit into from
Apr 17, 2022
Merged

fix: XLA tests updated #1413

merged 1 commit into from
Apr 17, 2022

Conversation

bagxi
Copy link
Member

@bagxi bagxi commented Apr 17, 2022

Pull Request FAQ

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest requirements? Please attach the notebook link.
  • Have you run colab minimal CI/CD with minimal requirements? Please attach the notebook link.
  • Have you checked XLA integration? Please attach the notebook link.
  • Have you checked distributed XLA integration? Please attach the notebook link.

@bagxi bagxi requested a review from Scitator as a code owner April 17, 2022 11:01
@bagxi bagxi self-assigned this Apr 17, 2022
@bagxi bagxi requested a review from ditwoo as a code owner April 17, 2022 11:01
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bagxi bagxi force-pushed the fix_xla_notebooks branch 2 times, most recently from 6ab4e08 to 43c997a Compare April 17, 2022 13:42
@Scitator Scitator merged commit 53b4238 into master Apr 17, 2022
@mergify mergify bot deleted the fix_xla_notebooks branch April 17, 2022 14:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants