Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role name and user fileds to role source #104 #105 #106

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brendanheywood
Copy link
Contributor

Closes #104 #105

Copy link
Contributor

@marcusboon marcusboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests update

1) mod_cms\datasource_roles_test::test_get_data
Undefined property: stdClass::$coursealias

/var/www/site/mod/cms/classes/local/datasource/roles.php:131
/var/www/site/mod/cms/classes/local/datasource/base.php:242
/var/www/site/mod/cms/classes/local/renderer.php:58
/var/www/site/mod/cms/classes/local/renderer.php:164
/var/www/site/mod/cms/classes/local/renderer.php:150
/var/www/site/mod/cms/classes/local/renderer.php:129
/var/www/site/mod/cms/classes/local/lib.php:105
/var/www/site/mod/cms/lib.php:109
/var/www/site/course/modlib.php:137
/var/www/site/course/lib.php:3277
/var/www/site/mod/cms/tests/fixtures/test_import2_trait.php:79
/var/www/site/mod/cms/tests/datasource_roles_test.php:95
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80

2) mod_cms\renderer_test::test_get_data
Undefined property: stdClass::$email

/var/www/site/mod/cms/classes/local/datasource/roles.php:145
/var/www/site/mod/cms/classes/local/datasource/base.php:242
/var/www/site/mod/cms/classes/local/renderer.php:58
/var/www/site/mod/cms/tests/renderer_test.php:62
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80

ERRORS!
Tests: 49, Assertions: 193, Errors: 2.

@brendanheywood brendanheywood marked this pull request as draft November 1, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role data source should have all the standard user fields
2 participants