Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plagiarism_turnitin_users missing from privacy class #3

Open
wants to merge 1 commit into
base: master-fix-unit-test
Choose a base branch
from
Open

plagiarism_turnitin_users missing from privacy class #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions classes/privacy/provider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ public static function _get_metadata(collection $collection) {
'privacy:metadata:plagiarism_turnitin_files'
);

$collection->add_database_table(
'plagiarism_turnitin_users',
[
'userid' => 'privacy:metadata:plagiarism_turnitin_users:userid',
],
'privacy:metadata:plagiarism_turnitin_users'
);

$collection->link_external_location('plagiarism_turnitin_client', [
'email' => 'privacy:metadata:plagiarism_turnitin_client:email',
'firstname' => 'privacy:metadata:plagiarism_turnitin_client:firstname',
Expand Down
3 changes: 3 additions & 0 deletions lang/en/plagiarism_turnitin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@
$string['privacy:metadata:plagiarism_turnitin_client:submission_filename'] = 'The name of the submitted file is sent to Turntin so that it is identifiable.';
$string['privacy:metadata:plagiarism_turnitin_client:submission_content'] = 'Please be aware that the content of a file/submission is sent to Turnitin for processing.';

$string['privacy:metadata:plagiarism_turnitin_users'] = 'Information about Plagiarism Plugin Users.';
$string['privacy:metadata:plagiarism_turnitin_users:userid'] = 'The ID of the user who uses this plugin.';

$string['privacy:metadata:core_files'] = 'Turnitin Assignment stores files that have been uploaded to Moodle to form a Turnitin submission.';

$string['errorcode13'] = 'This submissionid - {$a->externalid} was not found in Turnitin. Unable to retrieve similarity score and other submission data.';
Expand Down
8 changes: 4 additions & 4 deletions tests/privacy/provider_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function test_get_metadata() {
$newcollection = provider::get_metadata($collection);
$itemcollection = $newcollection->get_collection();

$this->assertCount(3, $itemcollection);
$this->assertCount(4, $itemcollection);

// Verify core_files data is returned.
$this->assertEquals('core_files', $itemcollection[0]->get_name());
Expand All @@ -72,17 +72,17 @@ public function test_get_metadata() {
$this->assertArrayHasKey('student_read', $privacyfields);

// Verify plagiarism_turnitin_client data is returned.
$this->assertEquals('plagiarism_turnitin_client', $itemcollection[2]->get_name());
$this->assertEquals('plagiarism_turnitin_client', $itemcollection[3]->get_name());

$privacyfields = $itemcollection[2]->get_privacy_fields();
$privacyfields = $itemcollection[3]->get_privacy_fields();
$this->assertArrayHasKey('email', $privacyfields);
$this->assertArrayHasKey('firstname', $privacyfields);
$this->assertArrayHasKey('lastname', $privacyfields);
$this->assertArrayHasKey('submission_title', $privacyfields);
$this->assertArrayHasKey('submission_filename', $privacyfields);
$this->assertArrayHasKey('submission_content', $privacyfields);

$this->assertEquals('privacy:metadata:plagiarism_turnitin_client', $itemcollection[2]->get_summary());
$this->assertEquals('privacy:metadata:plagiarism_turnitin_client', $itemcollection[3]->get_summary());
}

/**
Expand Down