Fix #524 - Don't hit external storage during normal file upload #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rely on cron processes to do the work.
|
+1 from me, the main thought I had was around trying to update the metadata location without doing the read, but it's fine to just leave it all the cron to clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #524 for more background, but this prevents the plugin from hitting the external storage system during a normal file upload - and just relies on the scheduled task to manage the process completely instead.
The alternative here is to add a setting to turn this behaviour on/off but I'm not sure why we need to do this during the user file upload at all and we should just be able to rely on the scheduled tasks.
Passing to @brendanheywood to review - but happy for any other feedback from other interested parties too! :-)