Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval_metrics in R #252

Closed
annaveronika opened this issue Feb 12, 2018 · 6 comments · Fixed by #1672
Closed

eval_metrics in R #252

annaveronika opened this issue Feb 12, 2018 · 6 comments · Fixed by #1672

Comments

@annaveronika
Copy link
Contributor

annaveronika commented Feb 12, 2018

The python library has eval_metrics method, which calculates metric value on every iteration and returns for each requested metric its values on each iteration. We need to do the same for R. This will also allow for visualisation of metric values.

@PhilippPro
Copy link

PhilippPro commented Feb 13, 2018

http://mlr-org.github.io/mlr-tutorial/devel/html/measures/index.html

Probably not a good idea, if each package implement their own metrics. ;)

There is also the Metrics package.

@annaveronika
Copy link
Contributor Author

The calculation of metrics needs to be in C++, it's time critical and needs to be parallelized. That's why we write for metrics our own code.
But this issue is not about code of metrics calculation. I have updated the description, so that it's more clear.

@PhilippPro
Copy link

PhilippPro commented Feb 13, 2018

The calculation of metrics in general is not time consuming (at least the measures I know, maybe you can prove me wrong), so this is not the problem. It is even important for the user to be able to look how the measure is implemented which is a reason for implementing it in R.

But I see, that this issue is for something else. ;)

@annaveronika
Copy link
Contributor Author

It is bottleneck in many cases, depends on the metric. Especislly querywise (groupwise) metrics can be time consuming.
We calculate metrics during training and after training also (which this issue is about).
Training is on c++, if you call on every iteration function from R to calc metrics, it will slow down your training even for simple metrics for some datasets (with little amount of features).

@PhilippPro
Copy link

Ok, from this side it makes sense. On the other hand, the user maybe wants to specify his own metric.

@annaveronika
Copy link
Contributor Author

This is possible for python, see documentation. But in this case it might work slower.

robot-piglet pushed a commit that referenced this issue Jan 15, 2023
MERGED FROM #1672

ref:27752a25dfcff39e4707c67ab409341573aeb380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants