-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R-package cv #561
R-package cv #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several comments.
@nikitxskv I fixed the issues you pointed me to. |
@arcadia-devtools Ship it! |
We are currently planning our next release. For now the planned date is Friday. It would be super nice to have this pr in. Please do the changes asap. |
@nikitxskv, internal review request created: 645875 |
There is a build error $(SOURCE_ROOT)/catboost/R-package/src/catboostr.cpp:439:5: error: no matching function for call to 'CrossValidate' |
@brsoyanvn There is a build error, could you fix it? Do you see it when building? |
Hopefully, the error will go away if dereferencing is removed... |
@annaveronika There is no any build error now |
@brsoyanvn There are conflicts, could you resolve them? |
@brsoyanvn Do you plan to finish this? |
@annaveronika sorry for a delay, I was busy with other issues. I resolved the conflicts |
@arcadia-devtools Ship it! |
@nikitxskv, internal review request created: 675767 |
ref:aa3f69a58bee11d5e581ceed1fe056a8ea626655
Implemented catboost.cv function in R-package.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.