Apply suggestions from code review

catchorg · Jun 7, 2022 · 0ed85c6 · 0ed85c6
1 parent 4ec8b2a
commit 0ed85c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/src/catch2/reporters/catch_reporter_automake.hpp b/src/catch2/reporters/catch_reporter_automake.hpp
@@ -18,6 +18,8 @@ namespace Catch {
 
     class AutomakeReporter final : public StreamingReporterBase {
     public:
+        // GCC5 compat: we cannot use inherited constructor, because it
+        //              doesn't implement backport of P0136
         AutomakeReporter(ReporterConfig&& _config):
             StreamingReporterBase(CATCH_MOVE(_config))
         {}

diff --git a/src/catch2/reporters/catch_reporter_cumulative_base.hpp b/src/catch2/reporters/catch_reporter_cumulative_base.hpp
@@ -90,6 +90,8 @@ namespace Catch {
         using TestCaseNode = Node<TestCaseStats, SectionNode>;
         using TestRunNode = Node<TestRunStats, TestCaseNode>;
 
+        // GCC5 compat: we cannot use inherited constructor, because it
+        //              doesn't implement backport of P0136
         CumulativeReporterBase(ReporterConfig&& _config):
             ReporterBase(CATCH_MOVE(_config))
         {}

diff --git a/src/catch2/reporters/catch_reporter_streaming_base.hpp b/src/catch2/reporters/catch_reporter_streaming_base.hpp
@@ -18,6 +18,8 @@ namespace Catch {
 
     class StreamingReporterBase : public ReporterBase {
     public:
+        // GCC5 compat: we cannot use inherited constructor, because it
+        //              doesn't implement backport of P0136
         StreamingReporterBase(ReporterConfig&& _config):
             ReporterBase(CATCH_MOVE(_config))
         {}