integration branch does not compile

[wichert]

I wanted to try your fix for #5, but the current single include from the integration branch does not compile for me:

../../include/catch/catch.hpp: In instantiation of ‘Catch::ExpressionLhs<const unsigned int&>’:
../../src/tests/article.cc:15:   instantiated from here
../../include/catch/catch.hpp:942: error: forming reference to reference type ‘const unsigned int&’
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = unsigned int]’:
../../src/tests/article.cc:15:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const unsigned int&>::ExpressionLhs(const unsigned int&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const unsigned int&>::ExpressionLhs(const Catch::ExpressionLhs<const unsigned int&>&)
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = stylist::Article::article_type]’:
../../src/tests/article.cc:16:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const stylist::Article::article_type&>::ExpressionLhs(const stylist::Article::article_type&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const stylist::Article::article_type&>::ExpressionLhs(const Catch::ExpressionLhs<const stylist::Article::article_type&>&)
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = int]’:
../../src/tests/article.cc:17:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const int&>::ExpressionLhs(const int&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const int&>::ExpressionLhs(const Catch::ExpressionLhs<const int&>&)
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = float]’:
../../src/tests/article.cc:20:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const float&>::ExpressionLhs(const float&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const float&>::ExpressionLhs(const Catch::ExpressionLhs<const float&>&)
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = time_t]’:
../../src/tests/article.cc:24:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const time_t&>::ExpressionLhs(const long int&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const time_t&>::ExpressionLhs(const Catch::ExpressionLhs<const time_t&>&)
../../include/catch/catch.hpp: In member function ‘Catch::ExpressionLhs<const T&> Catch::ExpressionDecomposer::operator->*(const T&) [with T = size_t]’:
../../src/tests/article.cc:249:   instantiated from here
../../include/catch/catch.hpp:1022: error: no matching function for call to ‘Catch::ExpressionLhs<const size_t&>::ExpressionLhs(const long unsigned int&)’
../../include/catch/catch.hpp:938: note: candidates are: Catch::ExpressionLhs<const size_t&>::ExpressionLhs(const Catch::ExpressionLhs<const size_t&>&)
...

[philsquared]

Ha! I just opened issues to report the same thing!
I can't fix this properly in GitHub until a bit later - but if you just go to line 942 and remove the const and ref it should work.
Sorry about that (and thanks for opening the bug - saved me from doing it)

[wichert]

I can make a pull request with that change so you can click on a merge button. would that help?

[philsquared]

Gah! I suck at GitHub. I accepted the merge and it applied it to Master.

[wichert]

Most likely the fault is mine here - the target branch is something you set when creating a pull request, not something you can set when merging.

[philsquared]

Hopefully this fixes it on integration (I am unable to repro on my machine)