Fix TrackerBase::close children completion check #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now verifies that all children have completed, instead of only the last.
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 123 123
Lines 3403 3403
=======================================
Hits 2847 2847
Misses 556 556 |
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
=========================================
+ Coverage 83.66% 83.9% +0.24%
=========================================
Files 123 123
Lines 3403 3403
=========================================
+ Hits 2847 2855 +8
+ Misses 556 548 -8 |
|
Thanks for the fix, I added a test for it to prevent later regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function now verifies that all children have completed, instead of only the last. This fixes the section exeuction bug I reported the other day.
GitHub Issues
Fixes #1670.