Fix CTest command issue with square brackets #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 136 136
Lines 5180 5180
=======================================
Hits 4464 4464
Misses 716 716 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 136 136
Lines 5180 5180
=======================================
Hits 4464 4464
Misses 716 716 |
horenmar
added
BugFix
Extras
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was that square brackets are in principle legal in the name of a test case, but CatchAddTests was passing them directly to the test executable, which interprets them as a tag. It now escapes these brackets along with commas in test case names.
GitHub Issues
Fixes #1634.