Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CATCH_BREAK_INTO_DEBUGGER be user-configurable #1846

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Make CATCH_BREAK_INTO_DEBUGGER be user-configurable #1846

merged 1 commit into from
Feb 1, 2020

Conversation

khyperia
Copy link
Contributor

Unfortunately, the project I work on supports platforms under NDA, and so I can't upstream the fixes here.

(It'd be really nice if all platform configuration macros like this were externally configurable! But just this one is the one we need right now.)

@khyperia
Copy link
Contributor Author

The test failure is Error: retrieving gpg key timed out., not sure how to retrigger tests

@horenmar
Copy link
Member

AFAIK only accounts with access to the repo are allowed to rerun Travis tests.

Anyway, the change looks reasonable enough, but I'd like to also see it added to the documentation. (See docs/contributing.md how to properly add a "introduced in" placeholder)

@horenmar horenmar added the Tweak label Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1846 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1846   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         131      131           
  Lines        3888     3888           
=======================================
  Hits         3354     3354           
  Misses        534      534

@khyperia
Copy link
Contributor Author

Let me know if that's what you were thinking of with documentation!

@horenmar
Copy link
Member

horenmar commented Feb 1, 2020

Thanks. The documentation was good enough but I noticed that it was a subheading of "Disabling Exceptions", so I pulled it out and rewrote slightly.

@horenmar horenmar merged commit 4a5bc0f into catchorg:master Feb 1, 2020
horenmar added a commit that referenced this pull request Feb 1, 2020
horenmar added a commit that referenced this pull request Feb 16, 2020
@khyperia khyperia deleted the configurable-catch-trap branch February 26, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants