catch_compiler_capabilities.h: use proper math define #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 86.27% 85.71% -0.56%
==========================================
Files 131 128 -3
Lines 3888 3204 -684
==========================================
- Hits 3354 2746 -608
+ Misses 534 458 -76 |
C++11 math requires _GLIBCXX_USE_C99_MATH_TR1 to be true with gcc/clang. Also fixes an issue with uClibc-ng where __UCLIBC__ is defined in features.h but that is not included here and is thus no-op.
|
Actually this has the same problem. hmmm... |
|
Either I can fix the missing decl warnings when I get around to it, or you will have to :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++11 math requires _GLIBCXX_USE_C99_MATH_TR1 to be true with gcc/clang.
Also fixes an issue with uClibc-ng where UCLIBC is defined in features.h but
that is not included here and is thus no-op.
Similar to how boost does it: https://github.com/boostorg/math/blob/5f8561bcfd4f1784e729acd333d3532e30adc477/include/boost/math/tools/roots.hpp#L863