Making target detection on Mac more robust #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.x #2157 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 138 138
Lines 5683 5683
=======================================
Hits 5046 5046
Misses 637 637 |
|
Thanks. |
|
@horenmar FYI, the conda-forge feedstock now indeed passes. By the way, would you be interested to be added as a maintainer for the conda-forge feedstock as well? |
|
No thanks. I already don't have time to keep up with maintaining Catch2 without external integrations 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2140