Suppress declared_but_not_referenced warning for NVHPC #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadwaik
force-pushed
the
nvhpc_unused_warning
branch
2 times, most recently
from
fcd48e8
to
37ed84a
Compare
Codecov Report
@@ Coverage Diff @@
## devel #2637 +/- ##
==========================================
+ Coverage 91.20% 91.25% +0.06%
==========================================
Files 188 189 +1
Lines 7757 7810 +53
==========================================
+ Hits 7074 7127 +53
Misses 683 683 |
Catch2 suppresses unused variable and equivalent warnings in a couple
of places, but most importantly, in the declaration of autoRegistrar
in test registry. This warning gets triggered by NVHPC compiler. The
current patch adds three macros, namely:
CATCH_INTERNAL_START_WARNINGS_SUPPRESSION
CATCH_INTERNAL_SUPPRESS_UNUSED_VARIABLE_WARNINGS
CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION
for the NVHPC Compiler which in particular prevents that warning from
occurring. The compiler is detected completely separately from the
other compilers in this patch, because from what I found out, NVHPC
defines __GNUC__ as well for some reason. (I suspect because it
advertises itself as GNU compatible.)
We also add a condition to make sure that the `__GNUC__` path is not
taken by the NVHPC compiler.
jbadwaik
force-pushed
the
nvhpc_unused_warning
branch
from
37ed84a
to
644294d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch2 suppresses unusued variable and equivalent warnings in a couple of places, but most importantly, in the declaration of autoRegistrar here. This warning gets triggered by
NVHPCcompiler. The current patch adds three macros, namely:CATCH_INTERNAL_START_WARNINGS_SUPPRESSIONCATCH_INTERNAL_SUPPRESS_UNUSED_VARIABLE_WARNINGSCATCH_INTERNAL_STOP_WARNINGS_SUPPRESSIONfor the NVHPC Compiler which in particular prevents that warning from occurring. The compiler is detected completely separately from the other compilers in this patch, because from what I found out,
NVHPCdefines__GNUC__as well for some reason. (I suspect because it advertises itself as GNU compatible.In any case, I can try to find out a more optimal way of adding this combination if you want.