correct argument references in CatchAddTests.cmake

[xandox]

In case when using DISCOVERY_MODE PRE_TEST and some REPORTER in catch_discover_tests
catch_discover_tests_impl fails with error

CMake Error at Catch2/CatchAddTests.cmake:101 (message):
  Error running test executable '':

    Result: No such file or directory
    Output: 

due wrong names for arguments

[codecov]

Codecov Report

Merging #2747 (db495ac) into devel (9c541ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2747   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         190      190           
  Lines        7855     7855           
=======================================
  Hits         7176     7176           
  Misses        679      679           

[horenmar]

Thanks, the changes look correct, but I cannot reproduce the issue on my end.

I cloned Catch2 at current devel commit, and made small reproducer:

$ cat CMakeLists.txt
cmake_minimum_required(VERSION 3.20)

project(test-discover-tests LANGUAGES CXX)

add_subdirectory(Catch2)

add_executable(tests tests.cpp)
target_link_libraries(tests PRIVATE Catch2::Catch2WithMain)

include(Catch)

enable_testing()
catch_discover_tests(tests
  DISCOVERY_MODE PRE_TEST
)

$ cat tests.cpp
#include <catch2/catch_test_macros.hpp>

TEST_CASE("abc") {}
TEST_CASE("def") {}
TEST_CASE("ghi") {}

$ cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug && ninja -C build && cd build && ctest
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test HAVE_FLAG__ffile_prefix_map__mnt_c_ubuntu_temp_discover_tests_tests_Catch2__
-- Performing Test HAVE_FLAG__ffile_prefix_map__mnt_c_ubuntu_temp_discover_tests_tests_Catch2__ - Success
-- Configuring done (8.9s)
-- Generating done (5.1s)
-- Build files have been written to: /mnt/c/ubuntu/temp/discover-tests-tests/build
ninja: Entering directory `build'
[109/109] Linking CXX executable tests
Test project /mnt/c/ubuntu/temp/discover-tests-tests/build
    Start 1: abc
1/3 Test #1: abc ..............................   Passed    0.06 sec
    Start 2: def
2/3 Test #2: def ..............................   Passed    0.07 sec
    Start 3: ghi
3/3 Test #3: ghi ..............................   Passed    0.05 sec

100% tests passed, 0 tests failed out of 3

Total Test time (real) =   0.41 sec

Can you provide more details on when the tests are not found?

[xandox]

Hello @horenmar.

It's not clearly viewed in diff. But if add REPORTER (REPORTER JUnit for example) to your example you will see a error.

[xandox]

this if
https://github.com/catchorg/Catch2/pull/2747/files#diff-61b5fe4313696c0a0e502bbfd71ebd640156e2093b4244b28db049241fa2e87eR84

[horenmar]

I see and can reproduce it now, thanks.