Set target_link_libraries visibility to PRIVATE for linking android log

[itacud95]

Description

Set visibility for target_link_libraries to PRIVATE when linking in log for Android.

INTERFACE should be used on dependencies from other than our source files.
PRIVATE should be used the include happens in our source files.

In this case (src/catch2/internal/catch_debug_console.cpp:20) the include is from our source file.

I encountered a issue with this when building Catch2 for Android in combination with BUILD_SHARED_LIBS. Changing the visibility to PRIVATE fixes the issue.

Reproduction:

cmake -Bbuild -DANDROID=on -DBUILD_SHARED_LIBS=on -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_ROOT/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86_64 && cmake --build build

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28c2f0b) 91.36% compared to head (7ea6531) 91.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #2815      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         197      197              
  Lines        8289     8289              
==========================================
- Hits         7573     7571       -2     
- Misses        716      718       +2     

[horenmar]

Thanks, this is indeed correct. I wonder how it came to be an INTERFACE link in the first place.