Fix float reproducibility tests on Apple Silicon chips #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These only need to be disabled on select x86 chips but are fine to run on all Apple CPUs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2845 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.02%
==========================================
Files 197 197
Lines 8379 8379
==========================================
- Hits 7641 7639 -2
- Misses 738 740 +2 |
horenmar
reviewed
Mar 19, 2024
| @@ -558,7 +558,7 @@ namespace { | |||
| // into smaller type when the type is saved into memory. This obviously | |||
| // leads to a different answer, than doing the math in the correct precision. | |||
| #if ( defined( _MSC_VER ) && _M_IX86_FP < 2 ) || \ | |||
| ( defined( __GNUC__ ) && !defined( __SSE2_MATH__ ) ) | |||
| ( defined( __GNUC__ ) && (defined( __i386__ ) || defined( __x86_64__ )) && !defined( __SSE2_MATH__ ) ) | |||
There was a problem hiding this comment.
Note that this does not actually fix the tests, this just enables them on M1 machines.
Secondary issue is that the original warning will still be present on platforms that correctly disable the tests.
Full fix is to keep this updated define, but also to
- move the
ifdefabove the block defining all theuniform_fp_test_params - Change the change the tests "uniform_floating_point_distribution can handle unitary ranges" not to rely on
uniform_fp_test_params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These only need to be disabled on select x86 chips but are fine to run on all Apple CPUs.