Design cleanups issues. #1560
Design cleanups issues. #1560
Conversation
…er spacing, cleaned up typography, responsive tables and global navigation, footer, fluid SVGs, and fewer content boxes.
…l and accordion css into pagestyle. make minor scoping additions to templates to try to prevent style conflicts for redundant styles. cleanup in css still very much needed
…ound, shape up some type here and there
|
Close to being ready. Some notes on what's left:
|
|
Good to go. Worth another round of browser testing first. |
|
Looks like this little guy has an over aggressive z-index? https://github.com/WPO-Foundation/webpagetest/blob/3d481243463ff10e98cc93a094ef26a6f924e485/www/pagestyle2.css#L2142
|
|
The request dialog box has some contrast issues (for both hover and non-hover states).
Looks like if we bump the default (see: https://github.com/WPO-Foundation/webpagetest/blob/3d481243463ff10e98cc93a094ef26a6f924e485/www/pagestyle2.css#L3399 ) to #61cbf6, we fix part of this.
Then, for the |
|
Thanks @tkadlec On those above edits now. Also, for the visual comparison tab where the field formatting looks bonked up, it seems to be an existing markup problem with the JS additions: Will get that too. |
|
Alright, fixes above are in. I believe we're good to go. |
Ready for merge!! but this is the PR for moving most views to a more fluid, responsive layout, particularly at smaller screen sizes.
It includes a content change for the global nav: the home link is removed. We should repeat that edit in other pages that are hosted elsewhere, like the logged-in test history and account pages.
AB#140590