Move Disable Image Format checkboxes to Advanced #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dvanced since Firefox supports these too. Closes #1558"
|
Where it lives now:
Ultimately, we should organize these better, but maybe that's something that should wait until #1560 lands. |
tkadlec
requested review from
jefflembeck and
scottjehl
and removed request for
jefflembeck
jefflembeck
approved these changes
Oct 8, 2021
|
Thanks @jefflembeck. Shipping. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to catchpoint/WebPageTest.agent#441, we now can use the image format checkboxes to toggle support in Firefox, so it makes sense to move this out of the "Chromium" only tab.
Most of the work was done on the agent. This moves the checkboxes and adds a little subtext to indicate which browsers the flags work in, but that's it.
This will close #1558
AB#140780