Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overflow scroll shadows for our side-scrolling metrics, filmstrips, waterfalls. Fixes #1690 #1702

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Add overflow scroll shadows for our side-scrolling metrics, filmstrips, waterfalls. Fixes #1690 #1702

merged 3 commits into from
Jan 28, 2022

Conversation

scottjehl
Copy link
Contributor

overflow.shadows.mov

@scottjehl
Copy link
Contributor Author

image

@scottjehl
Copy link
Contributor Author

in the filmstrips too!

Screen.Recording.2022-01-28.at.12.57.20.PM.mov

tkadlec
tkadlec approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@tkadlec tkadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here! Love the affordances. Tested in FF, Safari, Edge and Chrome and all were looking rock-solid.

🐑

@scottjehl scottjehl merged commit bbd841d into master Jan 28, 2022
@scottjehl scottjehl deleted the 1690 branch January 28, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkadlec tkadlec tkadlec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottjehl @tkadlec