update prod! #1727
Merged
update prod! #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Request): Add CPClient setting
NOTE: THERE ARE PLANS TO ADD BACK TESTS THAT ARE USER-SCOPED LEVEL OF PRIVATE Currently, WPT has two privacy settings: private and public. Public tests once showed up on the Test History page where _anybody_ could see them. That was fun, but it's no longer the case for us. So, now every test we run is private. BUT, there's a caveat to that. Our version of private just means "we don't list the URL anymore." It does not gate test results on their user capabilities. This is misleading. So, since there is no difference in how we treat public vs private tests, I'm getting rid of the concept of private tests until we hook up tests that are actually within the authorized visibility set of the user.
feat(privacy): removing private
* feat(Catchpoint Auth): Adding login/logout via CP This is a big commit. - Moved www/models to www/src, we will be following this format in the future for new files - Added linting/formating for anything within www/src (PSR12) - Added a Util class to start migrating things out of common_lib for easier testing/referencing - Add logging in, logging out (and the routes behind this*) * THIS REQUIRES AN NGINX RESTART * fixup! feat(Catchpoint Auth): Adding login/logout via CP
chore(format): remove carriage returns
…simpleadvanced fields.
This ensures a profile can be used if it's pages that don't have the simpleadvanced fields.
Add lighthouse to primary results nav
Get rid of the type for now, we need to have a mixed type in there, because default response can be whatever we want, but that's php 8
fix(Util): Type Error when null passed
Variables getting clobbered in php is a whole thing so this happened and took out our results page
Updating our AZDO sync action with the new board
fix(RequestContext): s/$request/$request_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.