Don't unnecessarily shard a single-run test #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added a setting to disable test sharding.
|
Are there any considerations to make for private instances where the number of runs and the resulting size of the upload may get quite large? |
|
Unless you explicitly disable sharding, there will be no change. If you
want that many runs run on a single machine and to be remote-processed,
then you can disable sharding but you'll want to make sure the web server
and PHP can handle the biggest post that will get sent.
…On Fri, Feb 4, 2022 at 6:26 PM Vince B ***@***.***> wrote:
Are there any considerations to make for private instances where the
number of runs and the resulting size of the upload may get quite large?
—
Reply to this email directly, view it on GitHub
<#1738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMOBLUOVZRBKN7OO324TLUZROD3ANCNFSM5NSZM63A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
For context, the specific use case this is setting up for is the http
archive where we run -2,000 test agents (and scaling up). The plan is to
have the agent generate the final har directly but that can only work if it
has the full test.
…On Fri, Feb 4, 2022 at 6:26 PM Vince B ***@***.***> wrote:
Are there any considerations to make for private instances where the
number of runs and the resulting size of the upload may get quite large?
—
Reply to this email directly, view it on GitHub
<#1738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMOBLUOVZRBKN7OO324TLUZROD3ANCNFSM5NSZM63A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and added a setting to disable test sharding.
The main impact this has for a single-run test is that the agent will send the first and repeat view results back together instead of incrementally. For multi-run tests with the setting turned on it lets the agent collect the full test result for possible edge-processing before sending it back.