Give interface SVGs the business #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefflembeck
reviewed
Mar 8, 2022
jefflembeck
reviewed
Mar 8, 2022
jefflembeck
reviewed
Mar 8, 2022
jefflembeck
suggested changes
Mar 8, 2022
|
@tigt we have a bit of a conflict on the logos (as they are new), then I think we'll be good to go |
|
Should I omit them from this PR to make it easier to merge? |
I think that’s a great idea |
jefflembeck
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly SVGOMG, but also I put some extra stink on it to make a strong impression and and rewrote a lot of them to be even smaller. GitHub’s rich diff viewer should come in very handy here.
Specific notes:
For
icon-webvitals-testing:letter-spacingwas previously used to make the word’s bounding box centered, buttextLengthis better-suited since it will Do The Right Thing if the font metrics ofsans-serifare differentFor
icon-advanced-testing: I was able to remove thecrispEdgessince the overhauled dimensions all became integers, but if that still doesn’t render correctly on some browsers it can be restoredThis also fixes a very subtle visual bug in the data URIs for the dropdown arrow: