Add Total Connection Time to the Request Details Dialog #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke it easier to see the combined impact of DNS+TCP+SSL. While we're in here, I also broke up the long list of request details to give it some categorization and, hopefully, make it easier to scan. Closes #1755.
jefflembeck
reviewed
Feb 23, 2022
www/waterfall.js
Outdated
| if (r['created'] !== undefined) | ||
| details += '<b>Discovered: </b>' + (r['created'] / 1000.0).toFixed(3) + ' s<br>'; | ||
| if (r['load_start'] !== undefined) | ||
| details += '<b>Request Start: </b>' + (r['load_start'] / 1000.0).toFixed(3) + ' s<br>'; | ||
| if (IsValidDuration(r['dns_ms'])) { | ||
| details += '<b>DNS Lookup: </b>' + htmlEncode(r['dns_ms']) + ' ms<br>'; | ||
| totalConnectionTime += parseFloat(r['dns_ms']); |
There was a problem hiding this comment.
Do we have a guarantee that anything we're passing into parseFloat is a string that can be cast to a Float? (if not, we probably want to take care of that somewhere so we don't end up with concatenating NaN in an error.
There was a problem hiding this comment.
Also, are we ever parsing fractions of milliseconds? if not, maybe cast to Number instead?
There was a problem hiding this comment.
Hmm....good call. I'll switch to Number.
Also, for validation, I'm thinking a Number.isNaN(totalConnectionTime) check at the end probably suffices, eh?
… check for the connection time just in case we ever get something funky back.
jefflembeck
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1755 by adding a Total Connection Time value to the request dialog box to make it easier see the combined impact of DNS+TCP+SSL.
Also broke up the long list of details to make it easier to scan.
Before:
After:
