Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of small improvements from the HTTP Archive work #1770

Merged
merged 6 commits into from
Mar 9, 2022

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Feb 28, 2022

  • Makes the GZip level configurable: Allows for space/cpu tradeoffs for the test data stored by the php (not the gzip fiules from the agent). Dropping the gzip level to 1 cut the time in half to write the test job file on the HA server. Defaults to 6 which is the original hard-coded value.
  • Added a flag (lighthouse=0) to the HAR export API to allow for disabling the including of lighthouse data in the HAR when it isn't needed.
  • Moved the daily test counter incrementing into APC using atomic incrementing instead of a locked filesystem file. This reduces the contention when lots of tests are being submitted concurrently and reduces the overhead for each test.
  • Fixed an exception that would be thrown in the HAR generation code if the browser data wasn't populated.
  • Added a check to not re-generate the page_data on the server if it was already processed on the agent.

Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out to me and looks great.

@tkadlec tkadlec merged commit 29253ce into catchpoint:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants