feat(api): delete multiple keys together #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to select multiple delete keys at the same time to delete together. It uses semantic html in which to do so. This _does_ mean that the page jumps to the top when you delete. Not super ideal, but it is what it is. On top of this, is some logic around deleting things and how checkboxes should work and how a solid select all situation should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to select multiple delete keys at the same time to delete
together. It uses semantic html in which to do so. This does mean that
the page jumps to the top when you delete. Not super ideal, but it is
what it is.
On top of this, is some logic around deleting things and how checkboxes
should work and how a solid select all situation should work.
This PR also includes a bug fix to make sure certain modals only load when they are supposed to (fixing an issue with race conditions around braintree forms)