Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched Google Oauth to composer and updated composer modules #2060

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Switched Google Oauth to composer and updated composer modules #2060

merged 4 commits into from
Jun 17, 2022

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Jun 16, 2022 •
edited

  • Switched to the latest Google client library using composer
  • Updated the composer config to allow php 8.0+ (since 8.1 doesn't satisfy ^7.4.0)
  • Updated all of the external libraries that were installed through composer

The only changes outside of composer are at the end:

  • Code changes to www/oauth/login.php to support the updated Google client library
  • Deleted lib/oauth since the library is now autoloaded from vendor
    • The CP oauth library and integration is unchanged

@pmeenan
Switched Google oauth to composer
e327601 
and updated composer modules
jefflembeck
jefflembeck reviewed Jun 16, 2022
View reviewed changes
www/oauth/login.php Outdated Show resolved Hide resolved
jefflembeck
jefflembeck approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jefflembeck jefflembeck merged commit bfc3750 into catchpoint:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

@tkadlec tkadlec Awaiting requested review from tkadlec

@scottjehl scottjehl Awaiting requested review from scottjehl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmeenan @jefflembeck