Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to force har to download #2083

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Add header to force har to download #2083

merged 1 commit into from
Jun 29, 2022

Conversation

vibaldem
Copy link
Contributor

Download HAR option loads contents into browser instead of downloading into a har file

Download HAR option loads contents into browser instead of downloading into a har file
@tkadlec
Copy link
Contributor

tkadlec commented Jun 28, 2022

Nice catch! Instead of adding the header though, I'm thinking we should use the download attribute (https://caniuse.com/download) on the link itself, like we do for the JSON file here: https://github.com/WPO-Foundation/webpagetest/blob/7c69cbd99aa361bb415f60d6d2fa912a3ac4b781/www/testinfo_command-bar.inc#L21

Should probably just add that to all those download links.... 🤔

@vibaldem
Copy link
Contributor Author

Nice catch! Instead of adding the header though, I'm thinking we should use the download attribute (https://caniuse.com/download) on the link itself, like we do for the JSON file here:

https://github.com/WPO-Foundation/webpagetest/blob/7c69cbd99aa361bb415f60d6d2fa912a3ac4b781/www/testinfo_command-bar.inc#L21

Should probably just add that to all those download links.... 🤔

That's neat, I didn't know about that attribute. Only issue seems to be that it saves it as a .json instead of .har, at least it does on our private instance.

@tkadlec
Copy link
Contributor

tkadlec commented Jun 29, 2022

@vibaldem Yeah...good point. So we need this after all. :)

Ok, merging this. Thanks for jumping on it!

@tkadlec tkadlec merged commit 4232fe0 into catchpoint:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants