Testlog refactoring: move single user history to a separate template #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2022 14:06
added 3 commits
July 19, 2022 15:12
| <?php if ($is_logged_in) : ?> | ||
| <label for="days" class="a11y-hidden">Select how far back you want to see</label> | ||
| <select name="days"> | ||
| <option value="1" <?php if ($days == 1) { |
There was a problem hiding this comment.
I see this formatting and I think "I'm gonna end up using a lot of ternary operators to not see this formatting"
deathbearbrown
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested webpagetest.org/testlog/7/ - looks identical before/after the change