Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sign up page with new designs for price selection. #2181

Merged
merged 10 commits into from
Jul 27, 2022

Conversation

deathbearbrown
Copy link
Contributor

Screen Shot 2022-07-26 at 12 48 31 PM
Screen Shot 2022-07-26 at 12 48 22 PM

This closes
#2119

One thing I cannot figure out is setting $tab globally in order to get the nav highlighted. I set it in signup-flow-step-1.php before the require_once of the header.inc, which is what checks for tab and sets it to string (tab is later used in wpt-header.php) but... it doesn't add to the global space....

@stoyan
Copy link
Contributor

stoyan commented Jul 26, 2022

Nit: possible to update the page title? Maybe it's just for power users but I have too many "WebPageTest" tabs :)

@stoyan
Copy link
Contributor

stoyan commented Jul 26, 2022

Nit: overlap in some screen sizes
Screen Shot 2022-07-26 at 4 24 37 PM

@scottjehl
Copy link
Contributor

This looks GREAT!

A couple very small things I noticed before it's ready to go:

  • At tablet-ish breakpoints, the top text gets crashy with black text over the purple. I think those breakpoints could have a good amount of margin under the purple header to give the text some space over the white.

image

- The WPT pro logo and text can swap out for this in an image element for alignment and consistency /images/wpt-logo-pro.svg

image

- minor thing, but for units, I've been trying to shift text a touch smaller, and the weight to normal or light for more texture. That impacts a couple places on this page:

image

and

image

- These x icons can be more consistent with the green checks by using this SVG: https://user-images.githubusercontent.com/214783/181105702-3c58def5-332d-4a7f-bb82-68b899750c4d.svg

@scottjehl
Copy link
Contributor

Nit: possible to update the page title? Maybe it's just for power users but I have too many "WebPageTest" tabs :)

I think that'd be a good global issue to look at yeah?

@scottjehl
Copy link
Contributor

A couple more weird ones.

  • On iOS, the yellow buttons have white text for me. Maybe iOS needs a reset on button text or appearance?
  • Also on iOS, the page breaks out horizontally. It looks like the button flex layout needs to wrap for the contact us box, and maybe the buttons up top need some slightly smaller font size, padding, margin?

@deathbearbrown
Copy link
Contributor Author

deathbearbrown commented Jul 26, 2022

  • more breakpoints for header overlap
  • change to WPT pro logo
  • switch bold font-weight to normal or lighter for units on buttons and callouts
  • update the X circle icon
  • iOS buttons are white text
  • iOS breaks weird around the contact us page?
  • add a new title (temporarily for this page just update it)

@deathbearbrown
Copy link
Contributor Author

I think I fixed the header overlap thing yesterday and must have not made a note of it cause I can't recreate it now. :/

…oint for content-header overlap for max-width 1500
Copy link
Contributor

@scottjehl scottjehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Thanks!

@deathbearbrown deathbearbrown merged commit eb66f1e into master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants