Use Blade for test history and a Console.log tab #2228
Conversation
stoyan
changed the title
|
The second diff resurrects the console.log part of this older page: https://www.webpagetest.org/screen_shot.php?test=220728_AiDc4D_D1J It's a new tab in the results with a URL like This page is a bit of a Frankenstein of all templates:
|
| } | ||
|
|
||
| tr.even { | ||
| background: whitesmoke; |
There was a problem hiding this comment.
how do you know all these color names??
There was a problem hiding this comment.
haha, I don't, unfortunately. They do seem handy :)
The css+html is a copy of the old code, that's currently not reachable: https://github.com/WPO-Foundation/webpagetest/blob/master/www/screen_shot.php#L88
So the purpose of the diff is two-fold: to bring back the feature and while Blade-ing
| <input id="filter" name="filter" type="text" onkeyup="filterHistory()" placeholder="Search"> | ||
| @if ($is_logged_in) | ||
| <label for="days" class="a11y-hidden">Select how far back you want to see</label> | ||
| <select name="days"> |
There was a problem hiding this comment.
needs id="days" to link to for
|
|
||
| <div class="overflow-container"> | ||
| <table id="console-log" class="translucent"> | ||
| <tr> |
| <tbody id="historyBody"> | ||
| @foreach ($test_history as $record) | ||
| <tr> | ||
| <th><input type="checkbox" name="t[]" value="{{ $record->getTestId() }}" /></th> |
There was a problem hiding this comment.
a11y hidden label needed
| <?php $even = false; ?> | ||
| <div id="test_results-container"> | ||
| <div id="test-1" class="test_results"> | ||
| <div class="test_results-content"> |
There was a problem hiding this comment.
this is legit just a comment, but dang that's a lot of wrapper divs
Currently commented out behind
// uncomment for Bladebecause I need a better setup to test more thoroughly the logged in case.But yes, it's working! Thanks to @jefflembeck's templates and because Blade lets you drop to just PHP I was able to reuse headers/footers/common as-is. And so no need for more competing code (see issue #2193)