Offer ability to remove TTFB variance from experiment comparison #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than 100ms, offers a link to view the comparison with TTFB ignored from all additive metrics. fixes #2329
tkadlec
reviewed
Sep 7, 2022
www/experiments/findings.inc
Outdated
| global $removeTTFBfromDiffs; | ||
| if ( | ||
| $removeTTFBfromDiffs | ||
| && ($metric === "render" |
There was a problem hiding this comment.
Instead of having to list out metric names again, could we append a value to the $diffMetrics array indicating whether or not a metric should be impacted by TTFB removal? Just thinking it avoids duplicating metric names.
There was a problem hiding this comment.
yeah, we need to move all these strings as const/struct of some sort at some point. String are too easy to mistype
stoyan
reviewed
Sep 7, 2022
www/experiments/findings.inc
Outdated
| global $removeTTFBfromDiffs; | ||
| if ( | ||
| $removeTTFBfromDiffs | ||
| && ($metric === "render" |
There was a problem hiding this comment.
yeah, we need to move all these strings as const/struct of some sort at some point. String are too easy to mistype
www/experiments/findings.inc
Outdated
| // check if metric might benefit from TTFB removal | ||
| function ignoreTTFBforMetric($metric) | ||
| { | ||
| global $removeTTFBfromDiffs; |
There was a problem hiding this comment.
Why not pass this to the function instead of using a global?
stoyan
approved these changes
Sep 7, 2022
tkadlec
reviewed
Sep 7, 2022
…e values lower in the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a check for TTFB differences and when they are greater than 100ms, offers a link to view the comparison with TTFB ignored from all additive metrics. fixes #2329