-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer ability to remove TTFB variance from experiment comparison #2331
Conversation
…r than 100ms, offers a link to view the comparison with TTFB ignored from all additive metrics. fixes #2329
www/experiments/findings.inc
Outdated
global $removeTTFBfromDiffs; | ||
if ( | ||
$removeTTFBfromDiffs | ||
&& ($metric === "render" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having to list out metric names again, could we append a value to the $diffMetrics array indicating whether or not a metric should be impacted by TTFB removal? Just thinking it avoids duplicating metric names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we need to move all these strings as const/struct of some sort at some point. String are too easy to mistype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Couple of nits inline...
www/experiments/findings.inc
Outdated
global $removeTTFBfromDiffs; | ||
if ( | ||
$removeTTFBfromDiffs | ||
&& ($metric === "render" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we need to move all these strings as const/struct of some sort at some point. String are too easy to mistype
www/experiments/findings.inc
Outdated
// check if metric might benefit from TTFB removal | ||
function ignoreTTFBforMetric($metric) | ||
{ | ||
global $removeTTFBfromDiffs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not pass this to the function instead of using a global?
…e values lower in the page
This implements a check for TTFB differences and when they are greater than 100ms, offers a link to view the comparison with TTFB ignored from all additive metrics. fixes #2329