Remove support for legacy /results/ paths #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That actual /old/ ones are ancient and have long-since been deleted so zero risk with those. I'm assuming the non-old waterfall and optimization check png's aren't used in the UI and the php is called directly but it would be worth verifying. |
|
Ahaa, there's one leftover: Thanks for the quick response, @pmeenan! |
|
Found a few more places, will address them separately and then come back to this |
|
The holdouts are addressed in #2343 |
jefflembeck
approved these changes
Sep 13, 2022
stoyan
added a commit
that referenced
this pull request
Sep 13, 2022
Move `/results/` urls to `/result/` for #2339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These paths were introduced at least as back as 11 years ago from what I can tell:
https://github.com/WPO-Foundation/webpagetest/blame/3ff126c63761d0a44a22074a0b8ce3b994a94e23/www/nginx.conf
@pmeenan can you think of a reason to keep them?