Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed couple of unused constants #2398

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Removed couple of unused constants #2398

merged 1 commit into from
Oct 4, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Oct 3, 2022

They are:

  • always true
  • not referenced in code

@scottjehl
Copy link
Contributor

This seems okay to me, but does the code have anything to do with private instance code?

jefflembeck
jefflembeck approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used is good for me :)

@jefflembeck jefflembeck merged commit eb2f53b into master Oct 4, 2022
@jefflembeck jefflembeck deleted the bareui branch October 4, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoyan @scottjehl @jefflembeck