Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants.inc and start weaning off __DIR__ #2399

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Oct 3, 2022

the result of dumping the constants:

    [APP_ROOT] => /var/www/webpagetest
    [WWW_PATH] => /var/www/webpagetest/www
    [ASSETS_PATH] => /var/www/webpagetest/www/assets
    [VER_WEBPAGETEST] => 21.07
    [VER_TYPOGRAPHY_CSS] => d5698bbc95c8ee894bacb869a2f2c8db
    [VER_LAYOUT_CSS] => f25358772e3c9df79b64b9e42c9a6e2a
    [VER_CSS] => 78d3606c1075a66147605bffcee74af1
    [VER_HEADER_CSS] => 697fe9b78a9b4d678f1b1f5e10003158
    [VER_ACCOUNT_CSS] => f5573738ecc2f0501fdf5d499652275d
    [VER_PRICE_CHANGER_JS] => 554bd234290355d73f3dfeba7afb106e
    [VER_FAQ_JS] => 806baf80caa10bf70b8728b24646d8f2
    [VER_BUTTON_CSS] => b891260d9a5598a3f00b133a976691d1
    [VER_JS] => 9d569a69e7d08a09fa85457f03309e1f
    [VER_JS_TEST] => ebb31ca6dd55baee8528e2430bcebd46
    [VER_JS_RUNNING] => 816b08ba201d238d171a00f583fc0efa
    [VER_JS_ACCOUNT] => 6ce5743d45b52529092c48b81ed7547a
    [VER_JS_ESTIMATE_TAXES] => d87beb152cc2c8c266b9e29dfa2f5f68
    [VER_JS_COUNTRY_LIST] => 26dbe29586f62719390d604a96a9b12a
    [UNKNOWN_TIME] => -1

Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a very nice change. We're going to want too make sure we use constant('NAME') as well, because of upcoming PHP version changes. Using CONSTANTS without it is deprecated.

@jefflembeck jefflembeck merged commit 38063bd into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants