Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow branch_name and branch_target to be read from files #52

Closed
xsorifc28 opened this issue Mar 5, 2020 · 1 comment
Closed

Allow branch_name and branch_target to be read from files #52

xsorifc28 opened this issue Mar 5, 2020 · 1 comment
Labels
enhancement good first issue help wanted

Comments

@xsorifc28
Copy link
Contributor

xsorifc28 commented Mar 5, 2020 •
edited

I'm not able to decorate PR since I can't read in the head and base branch from files.
Unless there is another method I'm aware of, it would be helpful to allow for this:

branch_name_file: some_output/branch_name
branch_target_file: some_output/branch_target

Currently, concourse gives an error:
Could not target requested branch: Target branch 'some_output/head_branch_name' does not exist
@headcr4sh
Copy link
Member

Seems like a legit feature request.
If you are willing to submit a PR, I'll gladly merge it. :-)

xsorifc28 pushed a commit to xsorifc28/concourse-sonarqube-resource that referenced this issue Mar 6, 2020
cathive#52 - Allow branch_name_file and branch_target_file
6dbbeb6 
Proposing solution for cathive#52
@xsorifc28 xsorifc28 mentioned this issue Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@headcr4sh @xsorifc28