Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript version in Dockerfile #87

Merged
merged 2 commits into from
May 2, 2023
Merged

Update typescript version in Dockerfile #87

merged 2 commits into from
May 2, 2023

Conversation

JR40159
Copy link
Contributor

@JR40159 JR40159 commented Apr 26, 2023

No description provided.

@holgerstolzenberg holgerstolzenberg self-assigned this Apr 26, 2023
@holgerstolzenberg holgerstolzenberg added the dependencies Pull requests that update a dependency file label Apr 26, 2023
@holgerstolzenberg
Copy link
Collaborator

We are struggling with setting up the build secrets properly at the moment.

@JR40159 Could you please rebase your PR with the most recent main branch!?

@JR40159
Copy link
Contributor Author

JR40159 commented May 2, 2023

We are struggling with setting up the build secrets properly at the moment.

@JR40159 Could you please rebase your PR with the most recent main branch!?

Updated the PR with latest on main :)

@holgerstolzenberg
Copy link
Collaborator

@JR40159 did you already receive a maintainer invitation from @headcr4sh ?

@holgerstolzenberg
Copy link
Collaborator

So it looks like the PR is not able to pick up the Github actions secrets by reason:
https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build

In order to not hinder the PR any more I am going to merge it.
We will have to look up deeper into https://securitylab.github.com/research/github-actions-preventing-pwn-requests/.

@holgerstolzenberg holgerstolzenberg merged commit 709aa27 into cathive:main May 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerstolzenberg holgerstolzenberg holgerstolzenberg approved these changes

Assignees

@holgerstolzenberg holgerstolzenberg

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JR40159 @holgerstolzenberg