Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot function without a shell #122

Closed
cottsay opened this issue Oct 19, 2014 · 1 comment · Fixed by #124
Closed

Cannot function without a shell #122

cottsay opened this issue Oct 19, 2014 · 1 comment · Fixed by #124

Comments

@cottsay
Copy link
Contributor

cottsay commented Oct 19, 2014

During the automated testing for the Fedora package for catkin_tools, it was discovered that context.py makes a call to the program stty. Without a shell, this program reports stty: standard input: Inappropriate ioctl for device, which causes ValueError: need more than 0 values to unpack.

Testing aside, this program should operate fine without a shell. Would it be appropriate to default to 80x24 if the call to stty fails?

Until this is fixed, I'm disabling automated testing for this package in Fedora.

@wjwwood
Copy link
Member

wjwwood commented Oct 19, 2014

@jbohren I think this is something you added, can you use this function which is already in catkin_tools in stead of calling out to stty:

https://github.com/catkin/catkin_tools/blob/master/catkin_tools/common.py#L258

It will gracefully fall back to 80 and also works on OS X and Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants