Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: suppressing warnings from catkin-pkg when just building #163

Merged
merged 1 commit into from
Apr 3, 2015

Conversation

jbohren
Copy link
Contributor

@jbohren jbohren commented Mar 16, 2015

@jbohren jbohren force-pushed the suppress-catkin-pkg-warnings branch 2 times, most recently from 0ac6410 to 52e77ae Compare March 17, 2015 13:43
@jbohren jbohren force-pushed the suppress-catkin-pkg-warnings branch 2 times, most recently from 9cf5064 to e2667dc Compare March 25, 2015 00:46
@jbohren jbohren force-pushed the suppress-catkin-pkg-warnings branch from e2667dc to 1581d86 Compare April 1, 2015 16:15
@jbohren
Copy link
Contributor Author

jbohren commented Apr 2, 2015

This is ready now that the latest catkin_pkg has been released.

@wjwwood
Copy link
Member

wjwwood commented Apr 2, 2015

I don't think it is appropriate to suppress the warnings in all the cases, or at least it's not immediately obvious why each of these instances suppresses the warnings.

Can you expand on why you think it's appropriate to suppress the warnings in each of these cases? If you want to disable them globally then I think it should be a command line configuration and it should not suppress the warnings by default.

The warnings are there for a reason and at least in the case of the package naming conventions we want to expose users to the fact their package name doesn't conform as soon as possible because changing the name of a package is harder the longer you wait. If you know what you're doing then you can disable them, but I just don't see the need to suppress them by default.

@jbohren jbohren force-pushed the suppress-catkin-pkg-warnings branch 2 times, most recently from b6d9c20 to 01a2569 Compare April 2, 2015 13:25
@jbohren
Copy link
Contributor Author

jbohren commented Apr 2, 2015

I don't think it is appropriate to suppress the warnings in all the cases, or at least it's not immediately obvious why each of these instances suppresses the warnings.

I've added justifications for each place warnings are suppressed.

One of the irritating things was that often the same warning would be printed out multiple times. Obviously this indicates that catkin build is scraping the same workspaces too many times, but regardless it just didn't work well with the way the catkin_tools command line tools work.

I've also added a formatted list of warnings that will get printed at the bottom of catkin list unless you call it with the --quiet option.

- adding a better-formatted (non-duplicated) list of warnings to `catkin
  list`
- adding a `--quiet` option to suppress warnings printed by `catkin
  list`
@jbohren jbohren force-pushed the suppress-catkin-pkg-warnings branch from 01a2569 to 1c3d60b Compare April 3, 2015 01:26
@wjwwood
Copy link
Member

wjwwood commented Apr 3, 2015

Ok, lgtm, thanks.

wjwwood added a commit that referenced this pull request Apr 3, 2015
common: suppressing warnings from catkin-pkg when just building
@wjwwood wjwwood merged commit 5aae537 into catkin:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants