Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing hyphen in theme names #7

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

ghostx31
Copy link
Member

@ghostx31 ghostx31 commented Mar 6, 2024

Closes #6

@nekowinston
Copy link
Contributor

nekowinston commented Mar 6, 2024

FWIW the change of introducing the space was fully intentional since other themes (bat --list-themes) do have spaces.

@ghostx31
Copy link
Member Author

ghostx31 commented Mar 6, 2024

Right, checked. Just updated the README to use wget instead of curl.

@nekowinston
Copy link
Contributor

We can also close #4 I guess since wget is now the only option because of the %20 urlencode issue.

@ghostx31 ghostx31 merged commit e5c2f64 into main Mar 6, 2024
@ghostx31 ghostx31 deleted the fix/theme-name-hyphen branch March 6, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The links are broken
2 participants