-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change build system, revamp docs & speedup generation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely shouldn't have been committed into source control in the first place.
Closed
1 task
nullishamy
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to give the repository a full overhaul, making it much easier to install and maintain.
TODO:
Store PNGs in the repository-
The PNGs are currently built everytime into a newbuild/
directory. This process calls inkscape over thousands of times each time. We should build the PNGs once into the same directory as the SVGs instead of a whole new directory so that the cache mechanism works properly.Tidy up makefile/build.sh script, add debug logging, etc.We still need to figure out a process of recolouring the SVGs fast but it looks
like they were hand-edited and put into source control. This is fine for the
time being and I'm not looking to optimise/improve that process.
BEGIN_COMMIT_OVERRIDE
build: generate zips in lowercase
perf: exponential speed-up in build time
END_COMMIT_OVERRIDE