This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
fix(status_bar): correctly apply latte colours #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chores: remove debug line
|
Is this maybe related to #168? |
Yes it's. You can see my comparison above |
|
when it will be merged? |
|
This repo is currently looking for new maintainers since the current maintainers have been busy lately. So I guess we should wait until they have time, or you can become one if you have experience in maintaining and working with a GTK theme. In the meantime, you could try out my forked repo to see if the problem is fixed for you, if not, please let me know so I can update my PR. |
isabelroses
reviewed
Apr 30, 2024
Co-authored-by: Isabel <isabel@isabelroses.com>
sgoudham
approved these changes
Apr 30, 2024
sgoudham
changed the title
scottames
pushed a commit
to scottames/dots
that referenced
this pull request
May 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [catppuccin/gtk](https://togithub.com/catppuccin/gtk) | patch | `v0.7.3` -> `v0.7.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>catppuccin/gtk (catppuccin/gtk)</summary> ### [`v0.7.4`](https://togithub.com/catppuccin/gtk/releases/tag/v0.7.4) [Compare Source](https://togithub.com/catppuccin/gtk/compare/v0.7.3...v0.7.4) #### What's Changed - Updated colloid submodule, this should fix theming in GNOME 46's app grid, calendar and more. ([catppuccin/gtk#169 by [@​OscarM3615](https://togithub.com/OscarM3615)) - Tabs are now the correct colour when using Latte ([catppuccin/gtk#166 by [@​ken-kuro](https://togithub.com/ken-kuro)) #### 🚧 Looking For Maintainers 🚧 We are currently looking for maintainers. For further information and background, see [#​164](https://togithub.com/catppuccin/gtk/issues/164). #### New Contributors - [@​OscarM3615](https://togithub.com/OscarM3615) made their first contribution in [catppuccin/gtk#169 - [@​abayomi185](https://togithub.com/abayomi185) made their first contribution in [catppuccin/gtk#170 - [@​isabelroses](https://togithub.com/isabelroses) made their first contribution in [catppuccin/gtk#172 - [@​sgoudham](https://togithub.com/sgoudham) made their first contribution in [catppuccin/gtk#173 <hr> **Full Changelog**: catppuccin/gtk@v0.7.3...v0.7.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change you've made in 355e123 has a small bug relate to the flavor name hardcode part. I believe the key that you want to compare to the hard code string is
identifierinstead ofname(https://github.com/catppuccin/python/blob/main/catppuccin/palette.py), however imo, we shouldn't hardcode it, so I make a simple change there.This commit will fix some pallete mismatch on current
lattevariant.Before:
After: