Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

chore: issue template #222

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: issue template #222

merged 2 commits into from
May 24, 2024

Conversation

nullishamy
Copy link
Contributor

@nullishamy nullishamy commented May 22, 2024 •
edited
Loading

Closes #189

@nullishamy
Copy link
Contributor Author

Once #221 lands, we should add a question similar to the GTK4 one that asks if the user has run the Flatpak commands. Blocked on this change being merged.

@isabelroses
Copy link
Member

ctp/nix is just a wrapper around the nixpkgs package. could it be listed in a different way perhaps?

@nullishamy
Copy link
Contributor Author

I think it makes sense to distinguish them. There may be a problem (potentially induced by us) that one or the other hasn't fixed / update to, would make narrowing it down easier, I think.

@isabelroses
Copy link
Member

I think it makes sense to distinguish them. There may be a problem (potentially induced by us) that one or the other hasn't fixed / update to, would make narrowing it down easier, I think.

ctp/nix just calls the nixpkg so they should always be on the same version.

@nullishamy
Copy link
Contributor Author

ctp/nix just calls the nixpkg so they should always be on the same version.

Would it not be possible for ctp/nix to fall behind nixpkgs? Do we have something automated to bump nixpkgs on ctp/nix when ctp/gtk releases a new version and it gets published to nixpkgs

@isabelroses
Copy link
Member

catppuccin/nix has no inputs. it only provides outputs, in form of modules. So it uses the users inputs for the package.

@nullishamy
Copy link
Contributor Author

Ah, I see. So the only case where there'd be an issue is if we changed the nixpkgs API for our package (which would break everything)? Seems fine to merge it into just "Nix", then?

@isabelroses
Copy link
Member

Exactly.

@nullishamy nullishamy added this to the v1.0.0 milestone May 24, 2024
isabelroses
isabelroses approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullishamy nullishamy requested a review from sgoudham May 24, 2024 12:32
@nullishamy nullishamy merged commit 1c336f2 into main May 24, 2024
1 check passed
@nullishamy nullishamy deleted the chore/issue-templates branch May 24, 2024 14:36
scottames pushed a commit to scottames/dots that referenced this pull request Jun 2, 2024
@renovate
chore(deps): update dependency catppuccin/gtk to v1 (#256)
804711c 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [catppuccin/gtk](https://togithub.com/catppuccin/gtk) | major |
`v0.7.5` -> `v1.0.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>catppuccin/gtk (catppuccin/gtk)</summary>

### [`v1.0.3`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.3)

[Compare
Source](https://togithub.com/catppuccin/gtk/compare/v1.0.2...v1.0.3)

> \[!IMPORTANT]
> **This will be the last release before this repository is archived.**
To understand why, see
[#&#8203;262](https://togithub.com/catppuccin/gtk/issues/262).

##### Performance Improvements

- improving performance, layout
([#&#8203;215](https://togithub.com/catppuccin/gtk/issues/215))
([cadc3e2](https://togithub.com/catppuccin/gtk/commit/cadc3e2ac24f93c6641f9f87ee5d044433c65ce7))

### [`v1.0.2`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/catppuccin/gtk/compare/v.1.0.0...v1.0.2)

Skipped 1.0.1 because of troubles with the release-please integration.

##### Bug Fixes

- alt tab menu
([#&#8203;209](https://togithub.com/catppuccin/gtk/issues/209))
([cae57c8](https://togithub.com/catppuccin/gtk/commit/cae57c80f81fd1cc40fab2655109b09fa97103b9))

### [`v1.0.0`](https://togithub.com/catppuccin/gtk/releases/tag/v1.0.0)

[Compare
Source](https://togithub.com/catppuccin/gtk/compare/v0.7.5...v.1.0.0)

This marks the first stable release after the massive refactorings we
did. Great work.

#### What's Changed

- build: new build system by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#178
- docs: update readme to support new build system
([#&#8203;183](https://togithub.com/catppuccin/gtk/issues/183)) by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#185
- refactor: build scripts by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#186
- docs(README): overhaul with updated information by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#187
- chore: Configure Renovate by
[@&#8203;renovate](https://togithub.com/renovate) in
[catppuccin/gtk#184
- fix: use `v1.0.0-rc1` for the install script by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#192
- refactor: reduce repeated code by
[@&#8203;isabelroses](https://togithub.com/isabelroses) in
[catppuccin/gtk#198
- docs: improve and fix the readme by
[@&#8203;somerand0mcat](https://togithub.com/somerand0mcat) in
[catppuccin/gtk#197
- fix: argument `--accent` behaves like the old argument by
[@&#8203;isabelroses](https://togithub.com/isabelroses) in
[catppuccin/gtk#200
- fix: use rc2 in the install script by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#201
- fix: actually apply our accents by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#199
- fix: disallow 'all' in install.py accent options by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#205
- ci: build in PRs by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#202
- feat: xfwm4 asset generation by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#206
- chore: update install script to rc3 by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#207
- docs: add resources to contributing guide by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#211
- docs: add new build reqs in by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#208
- fix: installation by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#210
- docs: upstreaming procedure by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#219
- docs: flatpak guide by
[@&#8203;somerand0mcat](https://togithub.com/somerand0mcat) in
[catppuccin/gtk#221
- chore: issue template by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#222
- feat: reintroduce black tweak as OLED-esque variant by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#213
- fix(patches): allow to work on windows by
[@&#8203;isabelroses](https://togithub.com/isabelroses) in
[catppuccin/gtk#226
- chore: update install script to rc4 by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#227
- fix: patches by
[@&#8203;isabelroses](https://togithub.com/isabelroses) in
[catppuccin/gtk#229
- ci: exit with non zero exit code when a build fails by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#231
- fix: allow all accents to be used by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#232
- chore: update install script to rc5 by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#233
- docs: architecture docs by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#242
- fix: add build suffix by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#241
- fix: xfwm4 assets by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#240
- fix: titlebars should be mantle not crust by
[@&#8203;nullishamy](https://togithub.com/nullishamy) in
[catppuccin/gtk#238

#### New Contributors

- [@&#8203;renovate](https://togithub.com/renovate) made their first
contribution in
[catppuccin/gtk#184

**Full Changelog**:
catppuccin/gtk@v0.7.5...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgoudham sgoudham sgoudham approved these changes

@isabelroses isabelroses isabelroses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Rework issue templates
3 participants
@nullishamy @isabelroses @sgoudham