-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add emoji for each flavor #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I like how the PR looks but I also had some other thoughts on whether we should also include more data including the codepoints and the short name? I don't know enough about emoji rendering and how much the other fields matter but figure it could be nice?
Maybe something like:
"emoji": {
"rendered": "🌻",
"codepoint": "U+1F33B",
"cldr_short_name": "sunflower"
}
Maybe I'm wayyy overthinking it but figured I'd comment it anyways, curious what you think
cc: @catppuccin/staff
Hmm IMO this isn't needed. As per your original issue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should run deno task generate
as part of the PR since the CI only runs deno task build
, unless you already have 😄
I did but iirc there weren't any changes? EDIT: Yeah no changes after running both commands. |
Closes #80.