Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rule for site healthy.gg #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nezred
Copy link

@nezred nezred commented Feb 18, 2024

This is just a really simple cookie settings popup that didnt seem to work, so i added this rule

@AUToelboell
Copy link
Collaborator

AUToelboell commented Feb 20, 2024

Hi, thank you for showing interest in the project. The rule you have submitted doesn't work. The rule isn't detected when the website is being loaded, also remember to use the "ShowingMatcher" instead of 2 matchers in "presentMatcher". None of the selectors you are using can be found on the site at all. to press accept you try to match on "button.modal-confirm.header5", but you should match on this instead "#hs-eu-confirmation-button". This example is representative for the other selectors aswell.

@nezred
Copy link
Author

nezred commented Feb 20, 2024

I apologize, I made a mistake in the website in the title, it should be healthygamer.gg and not healthy.gg, and upon closer observation it seems that i should make the link filter be within coaching.healthygamer.gg and not healthygamer.gg

I will fix the issue with ShowingMatcher

healthygamer.cc -> healthygamer.gg
@AUToelboell
Copy link
Collaborator

Since this only works on coaching.healthygamer.gg, the name needs a change. the "Displayfilter" in the "showingmatcher" needs to be toggled, and the "IfAllowAllAction" needs to be moved down in the "save_consent" method. otherwise it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants