Update UI test expectations to accommodate shiny 1.6 #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next version of shiny (which we plan on submitting to CRAN in a week or so), we've made several changes to HTML/CSS markup that cause your unit tests to fail (in non-meaningful ways), and so we ask you to submit a new version of cytomapper to CRAN as soon as possible to address this issue.
This PR fixes the issue by updating your test expectations to work with shiny 1.6 and also adds
skip_on_cran()
to skip tests that make particularly strong assumptions about the HTML/CSS that shiny generates. This will make it so shiny can continue to make HTML/CSS changes as needed without requiring periscope to send updates to CRAN (you can still monitor the tests locally and/or on a CI service like Github Actions or Travis CI).Let me know if you have any questions and please send a new version of periscope to CRAN with these updates to your tests as soon as possible.