avoid infinite loop causing crash on CCL #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbaggers#239 infinite loop stack overflow crash This fix from Devon7 cbaggers/cepl#350 (comment) Issue explained in Clozure/ccl#270 (comment) CLHS NOTINLINE says, In the presence of a compiler macro definition for function-name, a notinline declaration prevents that compiler macro from being used. The macroexpansion machinery contained in the fn library ignores this fact and recursively compiler-macroexpands the INTERN form which was explicitly declared NOTINLINE, which leads into infinite loops as demonstrated here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#239
infinite loop stack overflow crash
This fix from Devon7
cbaggers/cepl#350 (comment)
Issue explained in
Clozure/ccl#270 (comment)
CLHS NOTINLINE says,
In the presence of a compiler macro definition for function-name,
a notinline declaration prevents that compiler macro from being used.
The macroexpansion machinery contained in the fn library ignores this fact
and recursively compiler-macroexpands the INTERN form which was explicitly
declared NOTINLINE, which leads into infinite loops as demonstrated here.