Skip to content

Commit

Permalink
Merge pull request #1 from petarpetrovt/master
Browse files Browse the repository at this point in the history
Drop windows desktop SDK depedency
  • Loading branch information
cbenard committed Oct 14, 2021
2 parents 2ccf1cb + f210c9b commit 3d6d5ee
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ I renamed it, but all the types are still in the original namespace so this shou

More documentation would be appreciated via PRs, but this library is only for backward compatibility with .NET Framework applications being brought into .NET Core and .NET 5+, so it should not be used for new projects.

The interactive service credential prompt is only available when targeting .NET Core 3.0+ since `System.Windows.Forms` is unavailable in .NET Standard 2.0. This functionality is untested (by me).
The interactive service credential prompt is only available when targeting .NET Core 5.0-windows+ since `System.Windows.Forms` is unavailable in .NET Standard 2.0. This functionality is untested (by me).

---

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>net5.0;net5.0-windows</TargetFrameworks>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
13 changes: 8 additions & 5 deletions System.ServiceProcess.Core/System.ServiceProcess.Core.csproj
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<AssemblyName>System.ServiceProcess.Core</AssemblyName>
<AssemblyTitle>System.ServiceProcess</AssemblyTitle>
<TargetFrameworks>netstandard2.0;netcoreapp3.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net5.0-windows</TargetFrameworks>
<RootNamespace>System.ServiceProcess</RootNamespace>
<UseWindowsForms>true</UseWindowsForms>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1589</NoWarn>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('net5.0'))">
<UseWindowsForms>true</UseWindowsForms>
</PropertyGroup>

<PropertyGroup>
<PackageId>Core.System.ServiceProcess</PackageId>
<Version>1.0.2</Version>
<Version>2.0.0</Version>
<Description>Porting of System.ServiceProcess for .NET Standard 2.0 and .NET Core 3.0 from the Microsoft .NET Reference Source.</Description>
<Product>Core.System.ServiceProcess</Product>
<Copyright>Copyright (C) Microsoft Corporation (Modifications by Chris Benard)</Copyright>
Expand All @@ -29,7 +32,7 @@
<ItemGroup>
<None Include="..\LICENSE.txt" Pack="true" PackagePath="$(PackageLicenseFile)"/>
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('netstandard'))">
<Compile Remove="Design\ServiceInstallerDialog.cs" />
<Compile Remove="Design\ServiceNameConverter.cs" />
Expand Down

0 comments on commit 3d6d5ee

Please sign in to comment.