Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop windows desktop SDK depedency #1

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

petarpetrovt
Copy link
Contributor

Adding package reference to Core.System.ServiceProcess when targeting .NET 5.0 (without windows forms) gives the following error:

NETSDK1136 The target platform must be set to Windows (usually by including '-windows' in the TargetFramework property) when using Windows Forms or WPF, or referencing projects or packages that do so.

This PR drops the windows desktop SDK dependecy for netstandard2.0 target framework, Updates the obsoleted netcoreapp3.0 target framework with net5.0-windows and updates the package version to 2.0.

@cbenard
Copy link
Owner

cbenard commented Oct 14, 2021

Pulled it down to look at it. Looks great. Thanks for the great PR!

@cbenard cbenard merged commit 3d6d5ee into cbenard:master Oct 14, 2021
@cbenard
Copy link
Owner

cbenard commented Oct 14, 2021

Had to fix the broken publish to NuGet action. I wasn't sure if I'd have time to look into it, but looks like switching it to runs-on: windows-2019 fixed part of it and then the author has abandoned it, so I had to use someone else's forked fix.

Anyway, version 2.0.1 is now on NuGet. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants