Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop windows desktop SDK depedency #1

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Drop windows desktop SDK depedency #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b2fd27
Remove windows desktop SDK dependency
Oct 14, 2021
f210c9b
Update README.md
petarpetrovt Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ I renamed it, but all the types are still in the original namespace so this shou

More documentation would be appreciated via PRs, but this library is only for backward compatibility with .NET Framework applications being brought into .NET Core and .NET 5+, so it should not be used for new projects.

The interactive service credential prompt is only available when targeting .NET Core 3.0+ since `System.Windows.Forms` is unavailable in .NET Standard 2.0. This functionality is untested (by me).
The interactive service credential prompt is only available when targeting .NET Core 5.0-windows+ since `System.Windows.Forms` is unavailable in .NET Standard 2.0. This functionality is untested (by me).

---

Expand Down
2 changes: 1 addition & 1 deletion System.ServiceProcess.Core.Tests/System.ServiceProcess.Core.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>net5.0;net5.0-windows</TargetFrameworks>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
13 changes: 8 additions & 5 deletions System.ServiceProcess.Core/System.ServiceProcess.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<AssemblyName>System.ServiceProcess.Core</AssemblyName>
<AssemblyTitle>System.ServiceProcess</AssemblyTitle>
<TargetFrameworks>netstandard2.0;netcoreapp3.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net5.0-windows</TargetFrameworks>
<RootNamespace>System.ServiceProcess</RootNamespace>
<UseWindowsForms>true</UseWindowsForms>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1589</NoWarn>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('net5.0'))">
<UseWindowsForms>true</UseWindowsForms>
</PropertyGroup>

<PropertyGroup>
<PackageId>Core.System.ServiceProcess</PackageId>
<Version>1.0.2</Version>
<Version>2.0.0</Version>
<Description>Porting of System.ServiceProcess for .NET Standard 2.0 and .NET Core 3.0 from the Microsoft .NET Reference Source.</Description>
<Product>Core.System.ServiceProcess</Product>
<Copyright>Copyright (C) Microsoft Corporation (Modifications by Chris Benard)</Copyright>
Expand All @@ -29,7 +32,7 @@
<ItemGroup>
<None Include="..\LICENSE.txt" Pack="true" PackagePath="$(PackageLicenseFile)"/>
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('netstandard'))">
<Compile Remove="Design\ServiceInstallerDialog.cs" />
<Compile Remove="Design\ServiceNameConverter.cs" />
Expand Down